Updated protobuf version to 3.25.5, and protobuf & jackson maven dependencies#12389
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12389 +/- ##
============================================
- Coverage 16.23% 16.23% -0.01%
+ Complexity 13378 13376 -2
============================================
Files 5657 5657
Lines 498932 498932
Branches 60552 60552
============================================
- Hits 81016 81003 -13
- Misses 408882 408901 +19
+ Partials 9034 9028 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates protobuf to version 3.25.5 and adds explicit Jackson and protobuf dependency declarations to manage transitive dependency versions effectively.
- Adds protobuf version property (3.25.5) and dependency management entries to enforce version consistency across the project
- Adds explicit Jackson dependencies to the KVM hypervisor plugin to ensure proper library availability
- Adds jackson-dataformat-cbor to the utils module
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pom.xml | Adds protobuf version property (3.25.5) and dependency management for protobuf-java and protobuf-java-util to override older versions pulled by mysql-connector-java |
| plugins/hypervisors/kvm/pom.xml | Adds explicit Jackson dependencies (core, annotations, databind, datatype-jsr310, module-jaxb-annotations) needed for JSON processing in the KVM plugin |
| utils/pom.xml | Adds jackson-dataformat-cbor dependency to support CBOR (Concise Binary Object Representation) data format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
this is marked for kvm but it looks like it will need full regression testing for all platforms. |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16302 |
|
@blueorangutan test |
|
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-15148)
|
|
@blueorangutan test matrix |
|
@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-15152)
|
|
[SF] Trillian test result (tid-15153)
|
|
[SF] Trillian test result (tid-15154)
|
|
[SF] Trillian test result (tid-15155)
|
4 participants
Description
This PR updates protobuf version to 3.25.5, and protobuf & jackson maven dependencies in KVM hypervisor plugin.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?